Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update settings modal to avoid overflow in mobile devices #71

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

headlessNode
Copy link
Member

Resolves #70.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest master.
  • Submitted against master branch.

Description

What is the purpose of this pull request?

This pull request:

  • add overflow:auto to allow for scroll and avoid overflow in the settings modal on mobile devices.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

I made the changes to the layout.css and ran make minify-css. Are there any other any build related tasks that I need to do?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Dec 3, 2024

@headlessNode Do you happen to have a GIF handy which shows the new behavior?

@headlessNode
Copy link
Member Author

@kgryte
XubuntuRunning-OracleVirtualBox2024-12-0315-48-36-ezgif com-video-to-gif-converter

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit 8ce558e into stdlib-js:master Dec 3, 2024
@headlessNode headlessNode deleted the fix-settings-menu branch December 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Overflow Issue in Settings: Last Checkbox text overflow in table
2 participants