fix(parser): throw error when concept is extending itself in JSON met…

…amodel form Signed-off-by: Stefan Blaginov <[email protected]>
stefanblaginov · Nov 22, 2023 · 7a9d181 · 7a9d181
1 parent 02da293
commit 7a9d181
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/packages/concerto-cto/lib/printer.js b/packages/concerto-cto/lib/printer.js
@@ -343,6 +343,9 @@ function declFromMetaModel(mm) {
             }
         }
         if (mm.superType) {
+            if (mm.superType.name === mm.name) {
+                throw new Error(`The declaration "${mm.name}" cannot extend itself.`);
+            }
             result += `extends ${mm.superType.name} `;
         }
         result += '{';

diff --git a/packages/concerto-cto/test/printer.js b/packages/concerto-cto/test/printer.js
@@ -62,4 +62,30 @@ describe('parser', () => {
             declarations: [],
         })).should.throw(Error, 'Unrecognized import');
     });
+
+    it('Should throw error for a self-extending declaration', () => {
+        (() => Printer.toCTO({
+            '$class': '[email protected]',
+            'namespace': '[email protected]',
+            'declarations': [
+                {
+                    '$class': '[email protected]',
+                    'name': 'Self_Extending',
+                    'isAbstract': false,
+                    'properties': [
+                        {
+                            '$class': '[email protected]',
+                            'name': 'foo',
+                            'isArray': false,
+                            'isOptional': true
+                        }
+                    ],
+                    'superType': {
+                        '$class': '[email protected]',
+                        'name': 'Self_Extending'
+                    }
+                }
+            ]
+        })).should.throw(Error, 'The declaration "Self_Extending" cannot extend itself.');
+    });
 });