-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Event
to be cheap to clone and allow it to be rolled back
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
commented
Feb 3, 2023
jayz22
commented
Feb 3, 2023
graydon
reviewed
Feb 3, 2023
…:retain` for efficient bulk update; add test.
jayz22
commented
Feb 7, 2023
jayz22
commented
Feb 7, 2023
graydon
reviewed
Feb 9, 2023
graydon
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #648 and #647.
Restructure the
Event
:MeteredVector
such that metering is taken care of automatically.Event
struct only by demand 1. when host is finished 2. when an error arises.Include
InternalEventsBuffer in the
RollbackPointand roll back
ContractEvents (keeping
DebugEvent`s) on contract failure.Here is the sample output of a failed cross-contract call (contracts
A
->B
andB
failed):Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]