Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/KAD-4016 #654

Merged
merged 11 commits into from
Jan 27, 2025
Merged

feature/KAD-4016 #654

merged 11 commits into from
Jan 27, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-4016
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

video of the feature

@gilbert-hernandez
Copy link
Contributor Author

@oakesjosh
This is ready for a review. Updates have been made after discussions with Saylor and Donaldo. There are four options, horizontal, stacked vertical, sideways down, and sideways up. There are SVG icons for the buttons.

@oakesjosh oakesjosh merged commit 68e6e5d into master Jan 27, 2025
22 checks passed
@oakesjosh oakesjosh deleted the feature/KAD-4016 branch January 27, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants