New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/KAD-4076 #657

Merged

oakesjosh merged 1 commit into master from bugfix/KAD-4076

Jan 29, 2025

Contributor

gilbert-hernandez commented Jan 29, 2025

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-4076
...

Checklist

I have performed a self-review.
No unrelated files are modified.
No debugging statements exist (Ex: console.log, error_log).
There are no warnings or notices in the wordpress error log.
Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

Tested with an existing instance of this block .
Tested creating a new instance of this block.
Tested with Dynamic content & Elements.


          KAD-4076 update selector to find search block

f0541fd

gilbert-hernandez requested a review from oakesjosh

January 29, 2025 22:51

Contributor Author

gilbert-hernandez commented Jan 29, 2025

Changed selector so that search form is located instead of just modal container. This prevents a console log when the search block isn't a modal.

oakesjosh approved these changes

View reviewed changes

oakesjosh merged commit 916e598 into master

20 checks passed

oakesjosh deleted the bugfix/KAD-4076 branch

January 29, 2025 23:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet