Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 32-bit support #1287

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Improve 32-bit support #1287

merged 4 commits into from
Sep 7, 2024

Conversation

Bolderaysky
Copy link
Contributor

@Bolderaysky Bolderaysky commented Sep 6, 2024

  • Added x86 GCC runner. It's based on existing GCC runner with minor changes, so it runs for GCC versions supported by glaze (12, 13, 14)
  • Minor fixes were made to allow building 32-bit version of glaze, which includes small tests adjustments and some minor changes like disabled decompression of large (> size_t) integers

These changes may potentially affect users of binary json with 32-bit systems (because of change in int_from_compressed, which otherwise caused compilation errors). Other than that, no one should be hurt :)

Fixes #1277

@stephenberry
Copy link
Owner

Nice, this looks good. Thank you so much! I'll merge this in. And, thanks for your notes on adding more checks for 32bit platforms.

@stephenberry stephenberry merged commit a4e9697 into stephenberry:main Sep 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error on 32-bit system
2 participants