Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: connection error handling in the control page #2164

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

mabasian
Copy link
Contributor

No description provided.

@mabasian mabasian requested a review from MaxTheGeeek January 13, 2025 13:06
MaxTheGeeek
MaxTheGeeek previously approved these changes Jan 13, 2025
@MaxTheGeeek MaxTheGeeek dismissed their stale review January 13, 2025 16:37

Not fixed yet.

@MaxTheGeeek
Copy link
Contributor

On the Control Page, any refresh displays the errors.

@mabasian
Copy link
Contributor Author

mabasian commented Jan 13, 2025

On the Control Page, any refresh displays the errors.

Refresh is only possible in dev mode; it’s not supported in the application. @daGscheid informed me that the error occurred due to a disconnect and reconnect.

@daGscheid
Copy link
Member

On the Control Page, any refresh displays the errors.

Refresh is only possible in dev mode; it’s not supported in the application. @daGscheid informed me that the error occurred due to a disconnect and reconnect.

fix the refresh please as well

@MaxTheGeeek MaxTheGeeek self-requested a review January 17, 2025 09:39
gbayasgalan
gbayasgalan previously approved these changes Jan 17, 2025
Copy link
Contributor

@gbayasgalan gbayasgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄

@MaxTheGeeek MaxTheGeeek merged commit 652c58a into stereum-dev:main Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants