FIX: Escaping Problem of Passwords on Import #2165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbayasgalan
reviewed
Jan 14, 2025
| //escape all passwords for shell | ||
| passwords = passwords.map((p) => { | ||
| let pass = p; | ||
| if (pass.includes('"')) pass = pass.replaceAll(/"/g, '\\"'); |
There was a problem hiding this comment.
Is it better to use a library to escape all potential special characters rather than manually escaping only some of them? For example: require('shell-escape')
There was a problem hiding this comment.
they're escaped by JSON.stringify. The main problem are the double and single quotes. And because JSON.stringify already does escaping i need to remove the extra \ introduced with '\'', which i use to escape single quotes because all other variants i tried didn't work. This means that some library wont help either. This was all more complex then i thought tbh 😅
There was a problem hiding this comment.
but i think there is another problem when the password includes \...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2163