Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNAseq updates #146

Merged
merged 26 commits into from
May 13, 2024
Merged

DNAseq updates #146

merged 26 commits into from
May 13, 2024

Conversation

adthrasher
Copy link
Member

@adthrasher adthrasher commented Apr 29, 2024 •
edited
Loading

Split the DNAseq logic into a core workflow. Adds a FASTQ entry point. Adds subsampling to both FASTQ and BAM entry points.

@adthrasher adthrasher self-assigned this Apr 29, 2024
@adthrasher adthrasher changed the title [WIP] DNA updates [WIP] DNAseq updates Apr 29, 2024
@adthrasher adthrasher changed the title [WIP] DNAseq updates DNAseq updates May 8, 2024
@adthrasher adthrasher marked this pull request as ready for review May 8, 2024 16:47
@adthrasher adthrasher requested a review from a-frantz May 8, 2024 16:47
a-frantz
a-frantz requested changes May 8, 2024
View reviewed changes
Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future lint rule will be that = are surrounded by spaces. I see a bunch of call statements without that whitespace. Please update.

workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-standard-fastq.wdl Show resolved Hide resolved
workflows/dnaseq/dnaseq-standard-fastq.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-standard-fastq.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-standard-fastq.wdl Outdated Show resolved Hide resolved
@adthrasher adthrasher requested a review from a-frantz May 10, 2024 13:27
a-frantz
a-frantz reviewed May 12, 2024
View reviewed changes
tools/bwa.wdl Outdated Show resolved Hide resolved
tools/bwa.wdl Outdated Show resolved Hide resolved
tools/samtools.wdl Outdated Show resolved Hide resolved
tools/util.wdl Outdated Show resolved Hide resolved
tools/util.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Show resolved Hide resolved
workflows/dnaseq/dnaseq-core.wdl Outdated Show resolved Hide resolved
a-frantz
a-frantz reviewed May 13, 2024
View reviewed changes
tools/bwa.wdl Outdated Show resolved Hide resolved
@adthrasher adthrasher requested a review from a-frantz May 13, 2024 17:31
@adthrasher adthrasher merged commit fde88f1 into main May 13, 2024
10 checks passed
@adthrasher adthrasher deleted the dna_updates branch May 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-frantz a-frantz a-frantz approved these changes

Assignees

@adthrasher adthrasher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adthrasher @a-frantz