udiskslinuxdrive: Mark external NVMe removable #1234
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, ok to test. |
src/udiskslinuxdrive.c
Outdated
| GUdevDevice *d; | ||
| const gchar **removable; | ||
|
|
||
| removable = g_udev_device_get_sysfs_attr_as_strv (parent, "removable"); |
There was a problem hiding this comment.
Any reason not to use the construct you've moved further down in the patch? I.e. use g_udev_device_get_sysfs_attr_as_boolean() which tests the presence or an empty file.
There was a problem hiding this comment.
Because it's a string instead of a boolean, i.e. ATTRS{removable}=="removable".
There was a problem hiding this comment.
Yeah, but look at the line 517 in your patch - it's an old code that retrieves the value as boolean. I guess it's just a trick treating non-empty string as TRUE and it was working for ages.
There was a problem hiding this comment.
Because it's really boolean. The sysfs attribute is created based on GENHD_FL_REMOVABLE flag. CD-ROM or USB drive have this.
OTOH, the NVMe external drive's removable is created based on DEVICE_REMOVABLE and it's a string.
There was a problem hiding this comment.
So is it enough to get this merged?
There was a problem hiding this comment.
Ahh, I see now. Didn't expect that.
Thunderbolt ports propagate "removable" attribute to its child devices
like external NVMe, so use the attribute to set removable accordingly.
Excerpt from `udevadm info -a /dev/nvme1n1`:
looking at parent device
'/devices/pci0000:00/0000:00:1c.0/0000:03:00.0/0000:04:04.0/0000:3a:00.0/0000:3b:01.0/0000:3c:00.0':
KERNELS=="0000:3c:00.0"
SUBSYSTEMS=="pci"
DRIVERS=="nvme"
...
ATTRS{removable}=="removable"
storaged-project#793
|
Cockpit tests failed for commit c362d98. @martinpitt, @jelly, @mvollmer please check. |
|
Sorry, not your fault. We reported that lvm failure to https://bugzilla.redhat.com/show_bug.cgi?id=2256433 and will disable the test in rawhide, as it causes an unsalvageable mess. Please ignore. Update: this happened, so if you force-push or retry the test it should work. |
Thunderbolt ports propagate "removable" attribute to its child devices like external NVMe, so use the attribute to set removable accordingly.
Excerpt from
udevadm info -a /dev/nvme1n1:looking at parent device
'/devices/pci0000:00/0000:00:1c.0/0000:03:00.0/0000:04:04.0/0000:3a:00.0/0000:3b:01.0/0000:3c:00.0':
KERNELS=="0000:3c:00.0"
SUBSYSTEMS=="pci"
DRIVERS=="nvme"
...
ATTRS{removable}=="removable"
#793