Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add a more robust test case for LVM devices file #1264

Conversation

vojtechtrefny
Copy link
Member

Follow up for #1257, we need a test that works even when there are some old/invalid entries in the devices file.

Follow up for storaged-project#1257, we need a test that works even when there are
some old/invalid entries in the devices file.
Copy link

Cockpit tests failed for commit dd2bd35. @martinpitt, @jelly, @mvollmer please check.

@mvollmer
Copy link
Contributor

Cockpit tests failed for commit dd2bd35. @martinpitt, @jelly, @mvollmer please check.

Fedora 39 does look like a variant of cockpit-project/bots#5874: some lvm2 command hangs indefinitely, then cleanup fails because it can't get the LVM2 lock, and the rest of the tests can't get their desired loopback devices.

The Fedora 40 run has no artifacts so I can't check the screenshot, but the log has no dialog error either (which it would have if the dialog stays open because of an error). So this might also be a lvm2 hang.

I'll retry here, and also try to reproduce this separately.

@mvollmer
Copy link
Contributor

I'll retry here, and also try to reproduce this separately.

Oh, I can't. :-) Please ignore the Cockpit failures, then.

@martinpitt
Copy link
Contributor

The Fedora 40 run has no artifacts

Because it timed out after 60 mins, then the test is hard-killed.

@vojtechtrefny vojtechtrefny merged commit 3221246 into storaged-project:master Feb 27, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants