Ease the requirement for job inhibit locks #1342
Open
+119
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid placing system inhibit lock if desired.
…operations UDisks publishes a new job object whenever it sees an array in sync, repair or generally any other operation running. However this involves acquiring and holding a system inhibit lock for the whole duration of the operation, which for large disks may take hours or days. Besides, mdraid resync is a restartable operation, defeating the purpose for an inhibit lock. This is also causing problems for installation environments where UDisks is blocking post-installation reboot until the operation is done.
In certain use cases it might not be desirable or necessary to hold a system inhibit lock since the mdraid sync operations are typically restartable upon system restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default every job object creation always acquired system inhibit lock for the whole duration of the object lifecycle. That proved to be a problem for certain type of operations and in general should be avoided for jobs not started by UDisks, yet with a corresponding job object published for convenience.
This adds a new
no_inhibitargument to all theudisks_daemon_launch_family of functions. This is a preparation for potentially new general option for most method calls to avoid placing inhibit locks.Fixes #1174