Replaces staticcheck with golangci-lint #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egonelbre
approved these changes
Jul 2, 2024
egonelbre
reviewed
Jul 2, 2024
| #TODO#- whitespace # checks for leading/trailing newlines | ||
| disable: | ||
| - nolintlint # checks that nolint directives are correct | ||
| - staticcheck # we already use staticcheck separately |
There was a problem hiding this comment.
Oh, forgot, please add this into the enable section.
We run staticcheck separately in other repos, because the golangci-lint sometimes lags behind with the version.
Also, staticcheck is the most useful part of the checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed the config from storj/ci and only made one edit to disable linting comments on exported functions due to the volume of violations. This lint can be enabled later when someone has the time to address them.