Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

UI Router 1.*.* support #207

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

the-overengineer
Copy link

Provides a wrapper around the UI Router handling to allow for both UI Router 0.. and 1.. to be used. Refactors and abstracts the UI Router handling, also moving it into another module.

Was tested with UI Router v1.0.0-rc.1 for v1 support and v0.3.1 for backwards compatibility.

Fixes #176

@mraible
Copy link
Contributor

mraible commented Jan 26, 2017

If I try to build this branch, I get the following error:

$ grunt dist
Running "concat:build" (concat) task
File .tmp/build/stormpath-sdk-angularjs.js created.

Running "html2js:main" (html2js) task
Successfully converted 5 html templates to js.

Running "uglify:build" (uglify) task
>> 2 files created.

Running "docs" task

Running "clean:ngdocs" (clean) task
>> 21 paths cleaned.

Running "ngdocs:api" (ngdocs) task
Generating Documentation...
Warning: No parent named 'stormpath.ui-router.StormpathUIRouterTransition' for 'stormpath.ui-router.StormpathUIRouterTransition#isLegacy' in @methodOf. Use --force to continue.

Aborted due to warnings.

@the-overengineer
Copy link
Author

Thanks for checking it out @mraible, I forgot to check whether the docs can be built. My bad. It no longer reports error for the changed files on my side after the latest two commits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants