Refactored to upgradeable contracts (1/2) (Licensing, Modules) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
force-pushed
the
all-upgradeable-contracts
branch
from
99c5b23 to
1c3fa58
Compare
Ramarti
requested review from
jdubpark,
kingster-will,
leeren,
Spablob and
LeoHChen
LeoHChen
reviewed
Mar 21, 2024
LeoHChen
reviewed
Mar 21, 2024
LeoHChen
reviewed
Mar 21, 2024
LeoHChen
reviewed
Mar 21, 2024
LeoHChen
reviewed
Mar 21, 2024
|
The PR's diff is still displaying the code change that was checked in with PR #6. Please rebase it with the main branch to make it easier to review. |
Ramarti
force-pushed
the
all-upgradeable-contracts
branch
from
1c3fa58 to
b9390aa
Compare
Ramarti
force-pushed
the
all-upgradeable-contracts
branch
from
b9390aa to
9676ea8
Compare
It's rebased now |
It is |
This PR only deploys proxies, the upgrade is not tested because the storage layout script had issues. I'll do a separate PR |
kingster-will
approved these changes
Mar 24, 2024
Spablob
approved these changes
Mar 24, 2024
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 18, 2025
Add dispute propagation restriction
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
kingster-will
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR comes after #6
I'm splitting the bulk of upgradeables in 2 PRs to make review manageable.
Upgrades:
These contracts are now UUPSUpgradeable
These contracts are now Initializable.
(UUPS must be the last contract in the inheritance chain, but the rest must be made Initializable
These contracts are upgrade-safe without modification
Other