feat: tagging module events

storyprotocol · Jan 24, 2024 · a4287ee · a4287ee
1 parent d0df7d4
commit a4287ee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/contracts/interfaces/modules/ITaggingModule.sol b/contracts/interfaces/modules/ITaggingModule.sol
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.23;
+
+interface ITaggingModule {
+    event TagSet(string tag, address ipId);
+
+    event TagRemoved(string tag, address ipId);
+}
diff --git a/contracts/modules/tagging/TaggingModule.sol b/contracts/modules/tagging/TaggingModule.sol
@@ -8,8 +8,9 @@ import { ShortStringOps } from "contracts/utils/ShortStringOps.sol";
 import { EnumerableSet } from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol";
 import { Errors } from "contracts/lib/Errors.sol";
 import { IModule } from "contracts/interfaces/modules/base/IModule.sol";
+import { ITaggingModule } from "contracts/interfaces/modules/ITaggingModule.sol";
 
-contract TaggingModule is IModule {
+contract TaggingModule is IModule, ITaggingModule {
     using ShortStrings for *;
     using EnumerableSet for EnumerableSet.Bytes32Set;
     using EnumerableSet for EnumerableSet.AddressSet;
@@ -23,14 +24,15 @@ contract TaggingModule is IModule {
     function setTag(string calldata tag, address ipId) external returns (bool added) {
         // TODO: access control
         // TODO: emit
+        emit TagSet(tag, ipId);
         return _tagsForIpIds[ipId].add(ShortStringOps.stringToBytes32(tag));
     }
 
     function removeTag(string calldata tag, address ipId) external returns (bool removed) {
         // TODO: access control
+        emit TagRemoved(tag, ipId);
         return _tagsForIpIds[ipId].remove(ShortStringOps.stringToBytes32(tag));
     }
-
     function isTagged(string calldata tag, address ipId) external view returns (bool) {
         return _tagsForIpIds[ipId].contains(ShortStringOps.stringToBytes32(tag));
     }