This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
License integration with Royalty module #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
reviewed
Feb 1, 2024
Ramarti
approved these changes
Feb 1, 2024
- Modify UMLPolicy and framework manager to support multiple royalty policies, configured by license policy creation - Fix tests and scripts affected by the modified UMLPolicyFrameworkManager contract & UMLPolicy struct
jdubpark
added a commit
that referenced
this pull request
Feb 2, 2024
* test(wip): License with enforced Royalty * feat: Royalty distribution on Licensing * docs: Test detail comments * feat: License Royalty enhancements - Modify UMLPolicy and framework manager to support multiple royalty policies, configured by license policy creation - Fix tests and scripts affected by the modified UMLPolicyFrameworkManager contract & UMLPolicy struct * fix(test): cont. Change LSClaimer name to resolve conflict * test: Integration test fix, helper fix, Mock token fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the existing Licensing flows with the new Royalty module.
In the UML Policy Framework Manager, derivative IPAssets linked to parents via commercial licenses will be enforced to share any payments received. We utilize a modified version of 0xSplits with a custom Claimer contract by @Spablob to facilitate graph/tree-based license revenue sharing.
In this PR, we will introduce basic integration tests between UML licenses and 0xSplits-based royalty payments. Notably, the most basic integration test, which tests a root-child-child-child (four-level, single-line tree), can be found in
test/foundry/integration/big-bang/NftLicenseRoyalty.t.sol.