This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Internalize setRoyaltyPolicy call into LicenseRegistry #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
force-pushed
the
license-royalty-framework
branch
from
0c740d6 to
04b19c8
Compare
Ramarti
reviewed
Feb 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Policy Framework Managers (PFMs) are in charge of calling
setRoyaltyPolicy(RoyaltyModule) on license linking to parents, triggered byverifyLinkin LicenseRegistry'slinkIpToParents. The Royalty Module restricts the caller to the IPAccount owner OR registered PFMs.This opens up a huge vulnerability issue. Any PFMs can set royalty plicy on any IPAccounts. Since setting a royalty policy is an irreversible, one-time action per IPAccount, a malicious PFM can set royalty policy on random IPAccounts, thus preventing actual royalty policy registrations.
A proposed solution is whitelisting PFMs. Even with this solution, any whitelisted PFM can maliciously or accidentally call
setRoyaltyPolicyon any IPAccounts.A better, working solution is to call
setRoyaltyPolicyfrom the LicenseRegistry, after verifying links and checking the compatibility of parent licenses inlinkIpToParents.