Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

LicenseRegistry verifier conditions check #8

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

jdubpark
Copy link
Contributor

In License Registry, added TODO condition checks for

  • Minting License
  • Linking to Parent

Test cases run as expected with verifier values changed to true (for MockIPVerifier)

@jdubpark jdubpark requested a review from Ramarti January 20, 2024 06:22
Copy link
Contributor

@Ramarti Ramarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check if the TODOs you modified can be just deleted

contracts/registries/LicenseRegistry.sol Outdated Show resolved Hide resolved
contracts/registries/LicenseRegistry.sol Show resolved Hide resolved
@Ramarti Ramarti merged commit 1001bb7 into storyprotocol:main Jan 20, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants