Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Granular Verifier functions #9

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

jdubpark
Copy link
Contributor

Divide verifyParam into the three sections that require calling it, so we can pass in different parameters instead of jamming everything (including inputs not specified by users, such as mintAmount) into bytes call data.

function verifyMintingParam(address caller, uint256 mintAmount, bytes memory data) external returns (bool);
function verifyLinkParentParam(address caller, bytes memory data) external returns (bool);
function verifyActivationParam(address caller, bytes memory data) external returns (bool);

@jdubpark jdubpark requested a review from Ramarti January 20, 2024 07:16
Copy link
Contributor

@Ramarti Ramarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the approval thing

@jdubpark jdubpark merged commit 0cc0a10 into storyprotocol:main Jan 20, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants