This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Removes the module interface from the resolver interface #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
approved these changes
Feb 16, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver interface itself should not inherit the
IModuleinterface since we should not assume that all resolves are modules. Note that in the future we will likely deprecate resolvers altogether anyway.However, more interesting to note is that this was causing build failures for downstream contracts, as the
ResolverBasewas not properly making explicit from which contract thename()(main function provided byIModule) was being inherited from.