chore: add missing comments and duplicated asserts

storyprotocol · Aug 20, 2024 · 92adb72 · 92adb72
1 parent f3348ea
commit 92adb72
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/contracts/StoryProtocolGateway.sol b/contracts/StoryProtocolGateway.sol
@@ -263,6 +263,7 @@ contract StoryProtocolGateway is IStoryProtocolGateway, ERC721Holder, AccessMana
     /// @param derivData The derivative data to be used for registerDerivative.
     /// @param nftMetadata OPTIONAL. The desired metadata for the newly minted NFT.
     /// @param ipMetadata OPTIONAL. The desired metadata for the newly registered IP.
+    /// @param recipient The address to receive the minted NFT.
     /// @return ipId The ID of the registered IP.
     /// @return tokenId The ID of the minted NFT.
     function mintAndRegisterIpAndMakeDerivative(
@@ -556,6 +557,7 @@ contract StoryProtocolGateway is IStoryProtocolGateway, ERC721Holder, AccessMana
     /// @param licenseTemplate The address of the license template.
     /// @param licenseTermsId The ID of the license terms for the parent IP.
     /// @param amount The amount of licenses to mint.
+    /// @return The mint fee for the given parent IP.
     function _getMintFeeForSingleParent(
         address childIpId,
         address parentIpId,

diff --git a/contracts/interfaces/IStoryProtocolGateway.sol b/contracts/interfaces/IStoryProtocolGateway.sol
@@ -136,6 +136,7 @@ interface IStoryProtocolGateway {
     /// @param derivData The derivative data to be used for registerDerivative.
     /// @param nftMetadata OPTIONAL. The desired metadata for the newly minted NFT.
     /// @param ipMetadata OPTIONAL. The desired metadata for the newly registered IP.
+    /// @param recipient The address to receive the minted NFT.
     /// @return ipId The ID of the registered IP.
     /// @return tokenId The ID of the minted NFT.
     function mintAndRegisterIpAndMakeDerivative(

diff --git a/test/StoryProtocolGateway.t.sol b/test/StoryProtocolGateway.t.sol
@@ -594,7 +594,6 @@ contract StoryProtocolGatewayTest is BaseTest {
         assertTrue(ipAssetRegistry.isRegistered(ipIdChild));
         assertEq(tokenIdChild, 2);
         assertMetadata(ipIdChild, ipMetadataDefault);
-        assertMetadata(ipIdChild, ipMetadataDefault);
         (address licenseTemplateChild, uint256 licenseTermsIdChild) = licenseRegistry.getAttachedLicenseTerms(
             ipIdChild,
             0