fix(deploy&test): update deploy script and tests to use pre-deployed CREATE3 and apply minor fixes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
changed the title
kingster-will
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces updates and fixes to the deployment script and integration tests to align with the latest core protocol changes. The changes include:
CREATE3contract.package.jsonto use the consistent Solady and OpenZeppelin contract versions as the protocol core. ImportedCREATE3directly from the protocol core repository.CREATE3contract.TestProxyHelperand import it directly from the protocol core repository.storyprotocol/gha-workflows/.github/workflows/reusable-forge-code-coverage.yml@main, requires updates to accommodate changes in the updatedlcovversion.