docs: improve TODO comment for MockIPGraph limitation in RoyaltyWorkf… #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows test Description: Enhanced the TODO comment in RoyaltyWorkflows test to better document the current limitation of MockIPGraph regarding single-path calculations. This will help track the dependency on MockIPGraph's multi-path calculation support that needs to be implemented in the core Story Protocol repository. The comment now includes: - A placeholder for tracking issue number - Clear explanation of the expected vs actual behavior - Reference to the external dependency that needs to be updated
VolodymyrBg
requested review from
kingster-will,
sebsadface,
Spablob and
LeoHChen
as code owners
sebsadface
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lows test
Description:
Enhanced the TODO comment in RoyaltyWorkflows test to better document the current limitation of MockIPGraph regarding single-path calculations. This will help track the dependency on MockIPGraph's multi-path calculation support that needs to be implemented in the core Story Protocol repository.
The comment now includes: