Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-upgrade): add deploy and upgrade scripts for GroupingWorkflows #50

Merged

Conversation

sebsadface
Copy link
Member

@sebsadface sebsadface commented Sep 3, 2024

Description

This PR introduces deployment and upgrade logic for the GroupingWorkflows contract.

Key changes include:

  • Added deployment logic for GroupingWorkflows contract to the deployment script (Main.s.sol).
  • Added a separate deployment script for the MockRewardPool contract.
  • Created an upgrade script for GroupingWorkflows.
  • Updated the SPGNFT deploy and upgrade scripts to include a parameter for the GroupingWorkflows address.
  • Reorganized the scripts folder by adding deployment and upgrade directories, moving relevant scripts accordingly.

Test Plan

All existing and new deployment and upgrade scripts have been tested on the testnet, confirming that all scripts operate as expected. For details on the test results see the dropdown section below:

Test Results

Deployment Testing

  1. Deployment Script (Main.s.sol):
    The deployment script was run with seed 9032024 on the partner testnet, successfully deploying and verifying contracts at the following addresses:

    {
      "main": {
        "GroupingWorkflows": "0x3E89688EEae8CaC9bd5a27367351D6614E3E721F",
        "SPG": "0x11a3b6181cbfEDF77ce249953eF76BBD2108EB98",
        "SPGNFTBeacon": "0xE1a6AE889Df8842Faf332F93cb1c47B4820452FE",
        "SPGNFTImpl": "0xe7D443CDfDBa013085D0Abe6ECbB0cC79fA72221"
      }
    }

    These contracts can be verified on the block explorer:

  2. Contract Config:

    • Successfully called setNftContractBeacon for both GroupingWorkflows and SPG. Transaction details:

Upgrade Testing

  1. SPG Upgrade:
    A new SPG implementation was deployed and verified on the testnet at 0x211C760754C1F4969F95fB1E2e3A7c927EfCA041. See the contract details here.

    • Successfully called upgradeToAndCall on the SPG proxy contract to point to the new implementation. Transaction details.
  2. GroupingWorkflows Upgrade:
    A new GroupingWorkflows implementation was deployed and verified on the testnet at 0xBD598Db8D688Ab4488eC45dcb6238D7fB28700e6. See the contract details here.

    • Successfully called upgradeToAndCall on the GroupingWorkflows proxy contract to point to the new implementation. Transaction details.
  3. SPGNFT Upgrade:
    A new SPGNFT implementation was deployed and verified on the testnet at 0xBD961c2894B3E39af256CE6C6A99F246c6C0991C. See the contract details here.

    • Successfully called upgradeCollections on the SPG proxy contract to point SPGNFT to the new implementation. Transaction details.

Related Issue

This PR closes #49

Copy link

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It would be better mention the test procedures and result of upgrade scripts.

script/deployment/MockRewardPool.s.sol Outdated Show resolved Hide resolved
@sebsadface sebsadface force-pushed the deploy-upgrade-groupingworkflow branch from dd35e2e to 75ab763 Compare September 3, 2024 23:16
@sebsadface
Copy link
Member Author

LGTM. It would be better mention the test procedures and result of upgrade scripts.

^Updated PR description to include test results :)

@sebsadface sebsadface force-pushed the deploy-upgrade-groupingworkflow branch from 75ab763 to 44103aa Compare September 4, 2024 02:41
@sebsadface sebsadface merged commit f75ff08 into storyprotocol:main Sep 4, 2024
3 checks passed
@sebsadface sebsadface deleted the deploy-upgrade-groupingworkflow branch September 4, 2024 02:51
sebsadface added a commit to sebsadface/pp-v1 that referenced this pull request Sep 4, 2024
…kflows` (storyprotocol#50)

* feat(deploy): add `GroupingWorkflows` to deploy script

* feat(upgrade): add upgrade script for `GroupingWorkflows`

* feat(deploy): add deploy script for mock group reward pool

* chore(deploy-upgrade): update usage comments

* docs: update deploy-upgrade doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Deploy and Upgrade Scripts to include GroupingWorkflows
2 participants