Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enhance integration test logs for better traceability #80

Merged
merged 2 commits into from
Sep 27, 2024
Merged

chore: enhance integration test logs for better traceability #80

merged 2 commits into from
Sep 27, 2024

Conversation

sebsadface
Copy link
Member

Description

This PR introduces additional log statements for each test function in the integration tests added in PR #79. Below is a comparison showing the logs before and after the changes:

Before:

== Logs ==
  ==================================
  Running test RegistrationIntegration ...
  Test RegistrationIntegration  passed!
  ==================================

After:

== Logs ==
  🏃 Running _test_RegistrationIntegration_createCollection ...
  ✅ _test_RegistrationIntegration_createCollection passed!
  🏃 Running _test_RegistrationIntegration_createCollection ...
  ✅ _test_RegistrationIntegration_createCollection passed!
  🏃 Running _test_RegistrationIntegration_mintAndRegisterIp ...
  ✅ _test_RegistrationIntegration_mintAndRegisterIp passed!
  🏃 Running _test_RegistrationIntegration_registerIp ...
  ✅ _test_RegistrationIntegration_registerIp passed!
  🏃 Running _test_RegistrationIntegration_multicall_createCollection ...
  ✅ _test_RegistrationIntegration_multicall_createCollection passed!
  🏃 Running _test_RegistrationIntegration_multicall_mintAndRegisterIp ...
  ✅ _test_RegistrationIntegration_multicall_mintAndRegisterIp passed!

The new logs provide greater granularity, making it easier to trace each test case and its result.

kingster-will
kingster-will approved these changes Sep 27, 2024
View reviewed changes
Copy link

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebsadface sebsadface merged commit 28176d9 into storyprotocol:main Sep 27, 2024
3 checks passed
@sebsadface sebsadface deleted the test-log branch October 16, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingster-will kingster-will kingster-will approved these changes

@Spablob Spablob Awaiting requested review from Spablob Spablob is a code owner

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebsadface @kingster-will