Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the related methods #383

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Update the related methods #383

merged 4 commits into from
Jan 22, 2025

Conversation

bonnie57
Copy link
Collaborator

@bonnie57 bonnie57 commented Jan 17, 2025

Description

  • Update the workflow methods
  • Extract the validateLicenseTermsData, validateDerivativeData, and getLicenseData methods
  • Fix ABI conflict issue and remove override methods from abi
  • Fix the related tests including unit tests and integration tests

Test Plan

image ![Uploading image.png…]()

Related Issue

Add new methods in v1.3 #381

@jacob-tucker
Copy link
Contributor

Hi @bonnie57 , I have one comment: Any time we have maxRevenueShare, we should expect user to pass in a value 0-100, not 0-100,000,000. Note that we already do this for some commercialRevShare fields like we do here.

@bonnie57
Copy link
Collaborator Author

bonnie57 commented Jan 21, 2025

Hi @bonnie57 , I have one comment: Any time we have maxRevenueShare, we should expect user to pass in a value 0-100, not 0-100,000,000. Note that we already do this for some commercialRevShare fields like we do here.

I agree. maxRevenueShare is your expected behavior now. Did you see any different code from commercialRevShare?

@bonnie57 bonnie57 merged commit b3ca827 into v1.3 Jan 22, 2025
8 checks passed
@bonnie57 bonnie57 deleted the bonnie/SDK-43 branch January 22, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants