-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps [NET-1401]: update to Node.js 22 #2981
Open
harbu
wants to merge
7
commits into
main
Choose a base branch
from
NET-1401-update-network-monorepo-to-nodejs-22
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk-monorepo-to-nodejs-22
harbu
changed the title
deps: update to Node.js 22
deps [NET-1401]: update to Node.js 22
Jan 23, 2025
teogeb
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the PR description would be even more explicit about there current approach:
- we prefer v22, therefore we use v22 for the Docker image and
.nvmrc
- we require v20, therefore we use Node v20 types and
tsconfig
base
harbu
commented
Jan 24, 2025
teogeb
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Node.js to active LTS version 22. As per custom we maintain backwards compatibility (somewhat) to previous LTS 20.
In practice this means that
Future improvements
request
package with something else in autocertifier packages to get rid ofpunycode
transitive dependency and the deprecation warning. (See NET-1409 and NET-1404 for more information)Checklist before requesting a review
TODO
comments left behind are meant to be left in.