Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps [NET-1401]: update to Node.js 22 #2981

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

harbu
Copy link
Contributor

@harbu harbu commented Jan 21, 2025

Summary

Update Node.js to active LTS version 22. As per custom we maintain backwards compatibility (somewhat) to previous LTS 20.

In practice this means that

  • We prefer v22 and use it for the Docker image and .nvmrc
  • We still support v20 therefore we have it set for Node v20 types and tsconfig base ("lowest common denominator")

Future improvements

  • Update dependencies and replace request package with something else in autocertifier packages to get rid of punycode transitive dependency and the deprecation warning. (See NET-1409 and NET-1404 for more information)

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

Copy link

linear bot commented Jan 21, 2025

@github-actions github-actions bot added the cli-tools Related to CLI Tools Package label Jan 23, 2025
@harbu harbu requested review from teogeb and juslesan January 23, 2025 15:32
@harbu harbu changed the title deps: update to Node.js 22 deps [NET-1401]: update to Node.js 22 Jan 23, 2025
Copy link
Contributor

@teogeb teogeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the PR description would be even more explicit about there current approach:

  • we prefer v22, therefore we use v22 for the Docker image and .nvmrc
  • we require v20, therefore we use Node v20 types and tsconfig base

packages/cli-tools/test/utils.ts Outdated Show resolved Hide resolved
@harbu harbu requested a review from teogeb January 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli-tools Related to CLI Tools Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants