Add proper error message when incorrect custom offset value is entered #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hemahg <[email protected]>
|
MikeEdgar
reviewed
Jan 31, 2025
| @@ -215,6 +212,18 @@ export function ResetOffset({ | |||
| type="number" | |||
| min={0} | |||
| /> | |||
| {error && ( | |||
There was a problem hiding this comment.
My only concern here is that error could be other things besides the custom offset being out of range. The other options are reporting an error from Kafka or that a requested partition is not valid for the topic. I think those other options are much less likely than an out-of-range error, but just to mention that we would be masking them as an out-of-range error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper error message when incorrect custom offset value is entered