Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of Node ^20, ^22, ^23 #30

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

jirikapoun
Copy link
Contributor

@jirikapoun jirikapoun commented Jan 10, 2025

There are three unreleased commits in master, one of them already added support for Node 20, but using the version range <=20 which also allows for all older major versions, including those for which the support has already been dropped. Changed to ^20, following the previous convention.

CI target now runs tests also for the newly added versions (22, 23).

⚠️ Since the unreleased commit also drops support for Node versions 12, 14 and 16, the subsequent release should be a major version bump. But I guess this will be automatically handled by a CI job.

⚠️ One of these commits also migrates ESLint config to the new flat format, including the legacy override for the linebreak-style rule. Instead of fixing the ESLint execution for Windows platform, this override now breaks it – see CI logs. Moreover, the updated base config doesn't use this rule anymore, but @stylistic/linebreak-style which is an equivalent successor. Since it is now not being overriden, the two rules apply at the same time, so on Windows, each of them requires the opposite style and thus it's impossible to satisfy both of them at once. I solved the issue by removing the override completely, while enforcing LF endings on Windows using the .gitattributes file.

@robertrossmann robertrossmann self-assigned this Jan 13, 2025
@robertrossmann robertrossmann added the enhancement New feature or request label Jan 13, 2025
@robertrossmann robertrossmann merged commit dbfe39c into strvcom:master Jan 13, 2025
13 checks passed
@robertrossmann robertrossmann deleted the feat/node-20-22-23-support branch January 13, 2025 16:17
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants