Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sepolia #57

Merged
merged 10 commits into from
Jan 18, 2025

Conversation

invocamanman
Copy link
Contributor

@invocamanman invocamanman commented Oct 3, 2024

Let me know if i have to change something else^^

It works ( on my computer :P)

I bump the sp1-sdk to 2.0.0 version since the proof verification said:

Proving should work.: error: "InvalidArgument" message: "version SP1 circuit version v1.2.0 is not supported. Supported versions are: v1.1.0, v2.0.0, v3.0.0-rc1 - For more info, see: https://docs.succinct.xyz/generating-proofs/prover-network/versions"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sepolia spec took if from here: https://github.com/paradigmxyz/reth/blob/b4d5adeeb1a0a3dce0c6e49b102910e4e072f7a0/crates/chainspec/src/spec.rs#L58

@invocamanman invocamanman force-pushed the feat/add_sepolia_support branch from 46b5afa to 7c97db5 Compare October 3, 2024 05:22
@invocamanman
Copy link
Contributor Author

invocamanman commented Oct 3, 2024

Oki, for some reason, if i copy the specs it just fail computing the state root!?
somehow i cannot put timestamp in multiple forks like here: https://github.com/paradigmxyz/reth/blob/main/crates/ethereum-forks/src/hardfork/ethereum.rs#L363

I have to let only 1 timestamp and the rest to 0s, don't understand why yet TT ( i fix it in this commit)
buut it's workiing :D ^^

@leruaa
Copy link
Collaborator

leruaa commented Jan 15, 2025

Thanks for this PR @invocamanman, can you please solve the conflicts?

@invocamanman invocamanman force-pushed the feat/add_sepolia_support branch from 784ca2d to bf51cef Compare January 15, 2025 16:02
@invocamanman
Copy link
Contributor Author

done ^^ @leruaa

Copy link
Collaborator

@leruaa leruaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only a small nit.

I also launched CI.

crates/primitives/src/chain_spec.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@leruaa leruaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!
I fixed the remaining CI failures.

@leruaa leruaa merged commit 838aadf into succinctlabs:main Jan 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants