Features/addmul v2 #1936
Closed
Features/addmul v2 #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultraspicy
reviewed
Jan 15, 2025
| pub e_memory_records: MemoryWriteRecord, | ||
| pub c_ptr_memory: MemoryReadRecord, | ||
| pub d_ptr_memory: MemoryReadRecord, | ||
| pub e_ptr_memory: MemoryReadRecord, |
There was a problem hiding this comment.
what is the difference between e_memory_records and e_ptr_memory
| @@ -82,7 +82,7 @@ impl<F: PrimeField> MachineAir<F> for MemoryProgramChip { | |||
| let mut values = zeroed_f_vec(padded_nb_rows * NUM_MEMORY_PROGRAM_PREPROCESSED_COLS); | |||
| let chunk_size = std::cmp::max((nb_rows + 1) / num_cpus::get(), 1); | |||
|
|
|||
| let memory = program.memory_image.iter().collect::<Vec<_>>(); | |||
| let memory = program.memory_image.iter().sorted().collect::<Vec<_>>(); | |||
There was a problem hiding this comment.
we probably don't want to change their memory implementation
| @@ -99,11 +99,14 @@ impl PlonkVerifier { | |||
| public_inputs: &[[u8; 32]], | |||
| plonk_vk: &[u8], | |||
| ) -> Result<(), PlonkError> { | |||
| let plonk_vk = load_plonk_verifying_key_from_bytes(plonk_vk).unwrap(); | |||
| let proof = load_plonk_proof_from_bytes(proof, plonk_vk.qcp.len()).unwrap(); | |||
| let plonk_vk = load_plonk_verifying_key_from_bytes(plonk_vk)?; | |||
| @@ -146,6 +149,43 @@ jobs: | |||
| env: | |||
| CARGO_INCREMENTAL: 1 | |||
|
|
|||
| check: | |||
There was a problem hiding this comment.
this is github ci config file, no need to change i guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist