Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant .run() call in prove method #1957

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link

@mdqst mdqst commented Jan 21, 2025

Motivation

I noticed that the prove method already handles the proof execution internally, so calling .run() after it is unnecessary. This PR removes the redundant call to clean up the code and avoid potential confusion.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@leruaa
Copy link
Contributor

leruaa commented Jan 28, 2025

No, prove() creates a builder, and run() runs the prover.

@leruaa leruaa closed this Jan 28, 2025
@mdqst mdqst deleted the patch-2 branch January 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants