feat: contracts v2 #230
Merged
feat: contracts v2 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
reviewed
Oct 10, 2023
contracts/src/FunctionGatewayV2.sol
Outdated
| _verify(_functionId, inputHash, outputHash, _proof); | ||
|
|
||
| // Set the current verified call. | ||
| currentVerifiedFunctionId = _functionId; |
There was a problem hiding this comment.
Maybe cleaner to just put this all in currentVerifiedCall struct
puma314
reviewed
Oct 11, 2023
There was a problem hiding this comment.
I don't think we should delete this file, we should update it to the latest thing
contracts/test/FunctionGateway.t.sol
Outdated
There was a problem hiding this comment.
Don't think we should delete this file either, but agree that writing tests is lower priority
puma314
reviewed
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.