Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gnark plonky2 verifier #234

Merged
merged 31 commits into from
Oct 18, 2023
Merged

fix: gnark plonky2 verifier #234

merged 31 commits into from
Oct 18, 2023

Conversation

puma314
Copy link
Contributor

@puma314 puma314 commented Oct 12, 2023

No description provided.

@puma314 puma314 changed the title Fixing gnark plonky2 verifier (fix) Fixing gnark plonky2 verifier Oct 12, 2023
@puma314 puma314 changed the title (fix) Fixing gnark plonky2 verifier fix: Fixing gnark plonky2 verifier Oct 12, 2023
@puma314 puma314 marked this pull request as ready for review October 12, 2023 08:22
tamirhemo
tamirhemo reviewed Oct 12, 2023
View reviewed changes
plonky2x/verifier/circuit.go
VerifierData variables.VerifierOnlyCircuitData

// Circuit configuration that is not part of the circuit itself.
CommonCircuitData types.CommonCircuitData `gnark:"-"`
Copy link
Contributor

@tamirhemo tamirhemo Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'CommonCircuitData` a constant now?

jtguibas
jtguibas reviewed Oct 12, 2023
View reviewed changes
plonky2x/core/src/backend/function/mod.rs Outdated
// The VerifierDigest is stored on-chain as a bytes32, so we need to pad it with 0s
// to store it in the Solidity smart contract.
// Note that we don't need to do any sort of truncation of the top bits because the
// circuit digest already lives in the bn254 field because the WrappedCircuit config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why is bn254 lowercase but next line it's capitalized

Copy link
Contributor

@jtguibas jtguibas Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line breaks by sentence are unusual in this repo

either collapse to 100 cols or add another line between line breaks

@puma314 puma314 force-pushed the uma/modify-verifier branch from e44fee9 to d227b18 Compare October 13, 2023 00:44
@jtguibas jtguibas force-pushed the uma/modify-verifier branch from 163a6b0 to 41bb8bd Compare October 18, 2023 17:15
@jtguibas jtguibas changed the title fix: Fixing gnark plonky2 verifier fix: gnark plonky2 verifier Oct 18, 2023
@jtguibas jtguibas merged commit aebe1e9 into main Oct 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtguibas jtguibas jtguibas approved these changes

@tamirhemo tamirhemo tamirhemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puma314 @jtguibas @tamirhemo @ctian1