[Incomplete] Initial SDL3 support #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VL, SD, and IN backends for SDL3. We do this instead of using the combined SDL1/2 backends for SD and IN, as so many functions have been renamed. This does present some problems, as otherwise they share a lot of code, so one will likely end up outdated. Ideally, some of the 'generic' code, particularly in id_sd, can be split out a bit. Otherwise, this is still incomplete: - Some code, particularly in id_sd, is dead. - Graphics is probably broken on big-endian. (Though even SDL2 seemed broken on NetBSD/arm64eb, though that's weird enough I can't guarantee it'd work anyway.) - The pkg-config bits in the makefile are a bit ugly. - We'll possibly want support for vendored SDL3 at some point, too. - One day we'll want an SDL3_gpu based VL backend, but the renderer is good for now. - The SDL3 API is changing rapidly, so this needs to keep up One notable change is that all includes of "SDL.h" need to be replaced with an include of "ck_cross.h", which has the correct logic to include "SDL3/SDL.h" where needed. WITH_SDL is now set to 3 for SDL3 builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VL, SD, and IN backends for SDL3. We do this instead of using the combined SDL1/2 backends for SD and IN, as so many functions have been renamed. This does present some problems, as otherwise they share a lot of code, so one will likely end up outdated.
Otherwise, this is still incomplete: