Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank for the nice work ! In function of
__global__ void total_variation_add_grad_cuda_kernel
in the filetotal_variation_kenel.cu
, I found that there may be a problem in add grad.when reading the paper, I think that this function means to deal with the Aliasing in the voxel grid and let the voxel grid's value become more smooth.Therefore, if in 3D voxel grid ,the method of add variation in voxel grid maybe is to add grad in axis x,y,z. But I found that axis z was reused, so I change it to 'wx' in gradient axis 'x'.
I also run the experiment between the changes ,I found that the PSNR will raise by 0.02 in llff dataset ,Scene room.