Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated README.md to removed trailing commas, and renamed Sids to fix AWS IAM Policy Json Syntax error #91

Conversation

Johnyoat
Copy link
Contributor

The current documentation's IAM policy contains a trailing coma which gets flagged when it gets copied from the documentation to AWS console. The SID is also flagged with an Error Unsupported SID; to resolved this, I renamed the hyphened SID to camel case.

…n IAM CloudFormation policy

The current documentation's IAM policy contains a trailing coma which gets flagged when it gets copied from the documentation to AWS console. The SID is also flagged with an Error Unsupported SID; to resolved this, I renamed  the hyphened SID to camel case.
@Johnyoat Johnyoat changed the title doc: updated README.md to removed trailing commas, and renamed Sids to comply with AWS IAM Policy format doc: updated README.md to removed trailing commas, and renamed Sids to fix AWS IAM Policy Json Syntax error Apr 11, 2024
@Johnyoat Johnyoat changed the title doc: updated README.md to removed trailing commas, and renamed Sids to fix AWS IAM Policy Json Syntax error chore: updated README.md to removed trailing commas, and renamed Sids to fix AWS IAM Policy Json Syntax error Apr 11, 2024
@mats16 mats16 self-requested a review May 10, 2024 08:44
Copy link
Collaborator

@mats16 mats16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@mats16 mats16 merged commit e007ad2 into supabase-community:main May 10, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants