Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cover 100% of crypto with tests #1892

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat: cover 100% of crypto with tests #1892

merged 2 commits into from
Jan 10, 2025

Conversation

hf
Copy link
Contributor

@hf hf commented Dec 24, 2024

Covers a 100% of the crypto package with tests.

@hf hf requested a review from a team as a code owner December 24, 2024 17:49
@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12707682208

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 91 of 105 (86.67%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 65.435%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/hooks.go 7 21 33.33%
Totals Coverage Status
Change from base Build 12707475223: 0.7%
Covered Lines: 9814
Relevant Lines: 14998

💛 - Coveralls

@hf hf force-pushed the hf/cover-crypto-100 branch 3 times, most recently from 14b0ec5 to b1a9f64 Compare December 24, 2024 18:37
internal/crypto/password.go Outdated Show resolved Hide resolved
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

internal/crypto/crypto.go Outdated Show resolved Hide resolved
internal/crypto/utils.go Show resolved Hide resolved
@hf hf force-pushed the hf/cover-crypto-100 branch from 4409c7e to 8bbf818 Compare January 10, 2025 10:23
@hf hf merged commit 174198e into master Jan 10, 2025
2 checks passed
@hf hf deleted the hf/cover-crypto-100 branch January 10, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants