Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore not found error to check for pkce prefix later #1929

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • POST /verify fails for email change when PKCE is used and GOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLED is enabled because the query to retrieve the token returns an error if the token is not found instead of trying again with the pkce_ prefix

@kangmingtay kangmingtay requested a review from a team as a code owner January 29, 2025 18:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13037852442

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 65.6%

Files with Coverage Reduction New Missed Lines %
internal/models/one_time_token.go 2 69.05%
Totals Coverage Status
Change from base Build 13000101158: 0.02%
Covered Lines: 9863
Relevant Lines: 15035

💛 - Coveralls

@kangmingtay kangmingtay merged commit fbbebcc into master Jan 30, 2025
5 checks passed
@kangmingtay kangmingtay deleted the km/fix-pkce-verify-post branch January 30, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants