feat: onnx runtime upgrade #478
Draft
+143
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ndarray_linalg`: Since `ort` deps to `ndarray=0.16`, decided to remove this extra dependency. Normalization can be done in a simple small funtion instead of deriving it from an external crate.
using the `rc-9` apis to get the same results from older `rc-2`
Since `ONNX`version has been upgraded, the snapshots need to be recreated
- Since `ndarray_linalg` has been removed we need to manually apply L2 normalization
- Applying `dot product` between two embeddings to ensures that `mean_pool` and `normalize` is working properly
Sure! I will do it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: preparing for
ort rc-10that should come in feb 2025.What kind of change does this PR introduce?
Refactor, upgrade
What is the current behavior?
Current the
ort rust backendis usingort rc-2&onnx v1.19.2What is the new behavior?
This PR introduces:
ort: library upgrade fromrc-2torc-9onnx: support from1.19.2to1.20.1ndarray_linalg: removal of unnecessary library, that last release was about 2y agoTODO:
Stringtensors.ort rc-10Need help:
I would like to ask @nyannyacha 💚, if possible, to add updated
tests snapshotsfor other platforms as well dok6tests comparing to the latest version of that.