Support publication column lists #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passcod
force-pushed
the
feat/colsubset
branch
from
871284f to
8968e6d
Compare
imor
requested changes
Jan 15, 2025
|
LGTM, thanks for the PR. |
imor
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
#83
What is the new behavior?
We read from
pg_publication_relto figure out the subset of columns that are published.Additional context
This is done by adding a
publication: Option<&str>argument to theget_column_schemasmethod and its callers, up toPostgresSource::new, and then using that when present. I've managed to do the work preserving a single query, though that did make it a bit gnarly to support both subsetted tables and full tables.