Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Tus v1 #401

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Feat Tus v1 #401

merged 5 commits into from
Dec 29, 2023

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Dec 4, 2023

What kind of change does this PR introduce?

Feature

What is the new behavior?

This PR integrates the new tus-node-server v1 packages with additional extensions developed and contributed upstream.
We also revised the distributed locking mechanism using LISTEN / NOTIFY to closely match the TUS specification

@coveralls
Copy link

coveralls commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7130099581

  • 162 of 189 (85.71%) changed or added relevant lines in 8 files are covered.
  • 59 unchanged lines in 7 files lost coverage.
  • Overall coverage remained the same at 84.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/database/tenant.ts 3 4 75.0%
src/http/routes/tus/file-store.ts 2 3 66.67%
src/database/migrate.ts 3 5 60.0%
src/http/routes/tus/index.ts 31 33 93.94%
src/http/routes/tus/lifecycle.ts 65 75 86.67%
src/http/routes/tus/s3-store.ts 50 61 81.97%
Files with Coverage Reduction New Missed Lines %
src/database/migrate.ts 2 75.0%
src/http/routes/tus/s3-store.ts 2 82.72%
src/http/routes/tus/file-store.ts 6 66.67%
src/database/tenant.ts 8 59.13%
src/http/routes/tus/lifecycle.ts 9 78.67%
src/http/routes/tus/index.ts 15 87.78%
src/storage/uploader.ts 17 92.11%
Totals Coverage Status
Change from base Build 7031108426: 0.0%
Covered Lines: 7564
Relevant Lines: 8918

💛 - Coveralls

@fenos fenos force-pushed the feat/tus-stable-v1 branch from dc463eb to f84a4d6 Compare December 7, 2023 14:04
@fenos fenos force-pushed the feat/tus-stable-v1 branch from f84a4d6 to 8a4fda7 Compare December 7, 2023 15:09
@fenos fenos force-pushed the feat/tus-stable-v1 branch 6 times, most recently from c7bf566 to b5be4ec Compare December 27, 2023 11:26
@fenos fenos force-pushed the feat/tus-stable-v1 branch from b5be4ec to 77858aa Compare December 27, 2023 11:39
@fenos fenos force-pushed the feat/tus-stable-v1 branch 2 times, most recently from 60a4860 to f3ef681 Compare December 27, 2023 11:53
@fenos fenos force-pushed the feat/tus-stable-v1 branch from f3ef681 to 1c8fd48 Compare December 27, 2023 13:17
Copy link
Member

@inian inian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fenos fenos merged commit 5dc69c7 into master Dec 29, 2023
1 check passed
@fenos fenos deleted the feat/tus-stable-v1 branch December 29, 2023 13:17
Copy link

github-actions bot commented Jan 2, 2024

🎉 This PR is included in version 0.43.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants