Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reconcile orphan objects from admin endpoint #606

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jan 3, 2025

What kind of change does this PR introduce?

Feature

What is the new behavior?

This PR introduces management endpoints to determine orphans objects and or delete them for a specific project

  • List orphan objects (return a streamed response of db and s3 orphans)
  • Delete orphan objects (cleans up the files and or the rows in the database) which are marked as orphan

@fenos fenos force-pushed the admin/reconcile-orphan-objects branch 4 times, most recently from bbca2a6 to 78ab89e Compare January 13, 2025 08:56
@coveralls
Copy link

coveralls commented Jan 13, 2025

Pull Request Test Coverage Report for Build 12868487000

Details

  • 912 of 1340 (68.06%) changed or added relevant lines in 26 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 77.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/queue/event.ts 3 4 75.0%
src/storage/events/workers.ts 1 2 50.0%
src/storage/backend/s3/adapter.ts 47 56 83.93%
src/storage/backend/file.ts 2 12 16.67%
src/storage/backend/adapter.ts 2 13 15.38%
src/internal/testing/generators/array.ts 10 25 40.0%
src/storage/database/knex.ts 37 57 64.91%
src/test/utils/storage.ts 67 98 68.37%
src/storage/events/backup-object.ts 84 118 71.19%
src/storage/scanner/scanner.ts 396 472 83.9%
Files with Coverage Reduction New Missed Lines %
src/storage/events/workers.ts 1 33.33%
Totals Coverage Status
Change from base Build 12767884750: -0.7%
Covered Lines: 15169
Relevant Lines: 19469

💛 - Coveralls

@fenos fenos force-pushed the admin/reconcile-orphan-objects branch 3 times, most recently from 0aa5ea7 to 30bf141 Compare January 16, 2025 15:29
@fenos fenos force-pushed the admin/reconcile-orphan-objects branch from 30bf141 to f40009c Compare January 20, 2025 12:55
@fenos fenos merged commit cf23e7d into master Jan 21, 2025
1 check passed
@fenos fenos deleted the admin/reconcile-orphan-objects branch January 21, 2025 12:03
Copy link

🎉 This PR is included in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants