feat: search objects v2 #626
Open
+282
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fenos
force-pushed
the
feat/list-objects-v2
branch
from
a57ce80 to
a5b7fe6
Compare
fenos
force-pushed
the
feat/list-objects-v2
branch
from
a5b7fe6 to
96b7825
Compare
za-arthur
approved these changes
Jan 24, 2025
| @@ -0,0 +1,3 @@ | |||
| -- postgres-migrations disable-transaction | |||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS "objects_bucket_id_level_idx" | |||
There was a problem hiding this comment.
Do you not create an UNIQUE index here because you want to keep existing UNIQUE index?
| @@ -0,0 +1,2 @@ | |||
| -- postgres-migrations disable-transaction | |||
| CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS idx_name_bucket_unique on storage.objects (name COLLATE "C", bucket_id); | |||
There was a problem hiding this comment.
For the purpose of migration I think the index can be created without COLLATE "C", because the LIKE operator is not used.
But it shouldn't affect anything in terms of performance or functionality, so it is up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Super slow search functionality when there are millions of objects
What is the new behavior?
Fast, reliable and performant search functionality across hundreds of millions of objects