Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support mime 2.0.0 #1079

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: Support mime 2.0.0 #1079

merged 1 commit into from
Nov 11, 2024

Conversation

Vinzent03
Copy link
Collaborator

What kind of change does this PR introduce?

package upgrade

What is the current behavior?

mime 2.0.0 is not supported

What is the new behavior?

Support 1.2.0 and 2.0.0

Additional context

mime changelog We don't use that method so the update doesn't matter.

close #1074

@Vinzent03 Vinzent03 changed the title chore: support mime 2.0.0 chore: Support mime 2.0.0 Nov 7, 2024
@Vinzent03 Vinzent03 requested a review from dshukertjr November 7, 2024 20:19
@Vinzent03 Vinzent03 merged commit ba5ccd4 into main Nov 11, 2024
9 of 10 checks passed
@Vinzent03 Vinzent03 deleted the fix/mime branch November 11, 2024 23:10
@rickypid
Copy link
Contributor

@dshukertjr,

when will it be available on pub.dev?

Thank you very much.

@talamaska
Copy link

When we can expect this fix to be released. It's not in supabase_flutter 2.8.1, and the version of the storage_client is not updated and published with this fix?

@Vinzent03
Copy link
Collaborator Author

This change is indeed released with supabase_flutter 2.8.1. To actually upgrade to mime 2.0 You have to run pub upgrade, because we still support 1.0.0.

@rickypid
Copy link
Contributor

@Vinzent03

image

@Vinzent03
Copy link
Collaborator Author

I'm sorry and seems like you are right. The release script from melos didn't pick up the changes in storage_client and no new version got released.
@dshukertjr Could you try to release a new version with the version bump of mime.

@rickypid
Copy link
Contributor

@Vinzent03

don't worry, no problem. I'm waiting for the next release. one of the main problems is related to the score that is lowered by the dependencies not updated

@talamaska
Copy link

talamaska commented Nov 22, 2024

mime 2.0 has a breaking change of returning null for unknown mime type. It's not just a version update for the sake of a pub score.
I think you are already handling having mime type being nullable.

@rickypid
Copy link
Contributor

In my case I have no issues related to that method, regarding this PR @Vinzent03 indicated that it is not impactful on this package.

@dshukertjr dshukertjr changed the title chore: Support mime 2.0.0 feat: Support mime 2.0.0 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MIME to 2.0.0
4 participants