fix(supabase_flutter): session migration from hive to sharedPreferences now works properly #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
commented
Nov 24, 2023
Comment on lines
+199
to
+200
| final session = | ||
| Session.fromJson(jsonDecode(accessToken!)['currentSession']); |
There was a problem hiding this comment.
Here is the format of the session string stored on local storage for v1. Note that the session object is wrapped in a currentSession key.
https://github.com/supabase/supabase-flutter/blob/main/packages/gotrue/lib/src/types/session.dart#L81
Vinzent03
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We have a
MigrationLocalStorageclass for anyone migrating from supabase_flutter v1 to v2 so that the auth session would keep working while we have switched from using hive to using sharedPreferences for storing session data.There is currently a bug where the migration fails. This PR fixes the failing migration.