Merge pull request #323 from supabase/fix/hidden-reveal

fix: only check `hidden` if `reveal` is true, to correctly handle `reveal` changes
supabase · Feb 17, 2022 · 743b294 · 743b294 · vercel · Mar 1, 2022
2 parents 6dc46ee + a854563
commit 743b294
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/components/Input/Input.tsx b/src/components/Input/Input.tsx
@@ -61,7 +61,7 @@ function Input({
   ...props
 }: Props) {
   const [copyLabel, setCopyLabel] = useState('Copy')
-  const [hidden, setHidden] = useState(reveal)
+  const [hidden, setHidden] = useState(true)
 
   // if `type` is not assigned, default to text input
   if (!type) {
@@ -125,7 +125,7 @@ function Input({
             placeholder={placeholder}
             ref={inputRef}
             type={type}
-            value={hidden ? hiddenPlaceholder : value}
+            value={reveal && hidden ? hiddenPlaceholder : value}
             className={inputClasses.join(' ')}
             {...props}
           />
@@ -136,7 +136,7 @@ function Input({
               size={1}
             >
               {error && <InputErrorIcon size={size} />}
-              {copy && !hidden ? (
+              {copy && !(reveal && hidden) ? (
                 <Button
                   size="tiny"
                   type="default"
@@ -146,7 +146,7 @@ function Input({
                   {copyLabel}
                 </Button>
               ) : null}
-              {hidden && reveal ? (
+              {reveal && hidden ? (
                 <Button size="tiny" type="default" onClick={onReveal}>
                   Reveal
                 </Button>