don't try to send a request if there was no statements to send

superfly · Oct 23, 2023 · edbafb5 · edbafb5
1 parent 7197935
commit edbafb5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/crates/corro-client/src/lib.rs b/crates/corro-client/src/lib.rs
@@ -185,7 +185,7 @@ impl CorrosionApiClient {
     pub async fn schema_from_paths<P: AsRef<Path>>(
         &self,
         schema_paths: &[P],
-    ) -> Result<ExecResponse, Error> {
+    ) -> Result<Option<ExecResponse>, Error> {
         let mut statements = vec![];
 
         for schema_path in schema_paths.iter() {
@@ -261,7 +261,11 @@ impl CorrosionApiClient {
             }
         }
 
-        self.schema(&statements).await
+        if statements.is_empty() {
+            return Ok(None);
+        }
+
+        Ok(Some(self.schema(&statements).await?))
     }
 }
 

diff --git a/crates/corrosion/src/command/agent.rs b/crates/corrosion/src/command/agent.rs
@@ -43,9 +43,12 @@ pub async fn run(config: Config, config_path: &Utf8PathBuf) -> eyre::Result<()>
             .schema_from_paths(config.db.schema_paths.as_slice())
             .await
         {
-            Ok(res) => {
+            Ok(Some(res)) => {
                 info!("Applied schema in {}s", res.time);
             }
+            Ok(None) => {
+                info!("No schema files to apply, skipping.");
+            }
             Err(e) => {
                 error!("could not apply schema: {e}");
             }