chore: remove writes to snapshot #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriqaaq
force-pushed
the
perf/remove-snapshot-writes
branch
2 times, most recently
from
b8193bb to
b196cc3
Compare
arriqaaq
force-pushed
the
perf/remove-snapshot-writes
branch
3 times, most recently
from
069b260 to
d3ca252
Compare
arriqaaq
force-pushed
the
perf/remove-snapshot-writes
branch
from
d3ca252 to
dba4d3f
Compare
gsserge
reviewed
Nov 27, 2024
| .collect(); | ||
|
|
||
| // Sort by key | ||
| entries.sort_by(|a, b| a.0.cmp(b.0)); |
There was a problem hiding this comment.
I think it might actually be better to change the Write Set from HashMap to BTreeMap. That way you won't have to collect the latest values upfront in a vector and sort them, since BTreeMap's iterator is ordered. Maybe this will be enough to keep the scan perf in par with the current one.
|
Handled in #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.